tomtongue commented on code in PR #9927:
URL: https://github.com/apache/iceberg/pull/9927#discussion_r1523140669
##########
core/src/test/java/org/apache/iceberg/TableMetadataParserTest.java:
##########
@@ -37,30 +40,24 @@
import org.apache.iceberg.io.OutputFile;
import org.apache.iceberg.relocated.com.google.common.collect.Maps;
import org.apache.iceberg.types.Types.BooleanType;
-import org.junit.After;
-import org.junit.Assert;
-import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.junit.runners.Parameterized;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.TestTemplate;
+import org.junit.jupiter.api.extension.ExtendWith;
-@RunWith(Parameterized.class)
+@ExtendWith(ParameterizedTestExtension.class)
public class TableMetadataParserTest {
private static final Schema SCHEMA = new Schema(optional(1, "b",
BooleanType.get()));
- @Parameterized.Parameters(name = "codecName = {0}")
- public static Object[] parameters() {
- return new Object[] {"none", "gzip"};
+ @Parameters(name = "codecName = {0}")
+ protected static List<Object> parameters() {
+ return Arrays.asList("none", "gzip");
}
- private final String codecName;
+ @Parameter protected String codecName;
Review Comment:
Thanks for the review. Will revert to `private` in the next commit.
##########
core/src/test/java/org/apache/iceberg/TestMetadataUpdateParser.java:
##########
@@ -1036,43 +1038,39 @@ public void assertEquals(
private static void assertEqualsAssignUUID(
MetadataUpdate.AssignUUID expected, MetadataUpdate.AssignUUID actual) {
- Assert.assertEquals("UUIDs should be equal", expected.uuid(),
actual.uuid());
+ assertThat(actual.uuid()).isEqualTo(expected.uuid());
}
private static void assertEqualsUpgradeFormatVersion(
MetadataUpdate.UpgradeFormatVersion expected,
MetadataUpdate.UpgradeFormatVersion actual) {
- Assert.assertEquals(
- "Format version should be equal", expected.formatVersion(),
actual.formatVersion());
+ assertThat(actual.formatVersion()).isEqualTo(expected.formatVersion());
Review Comment:
I didn't think the description is needed because it obvious.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
