nastra commented on code in PR #9927:
URL: https://github.com/apache/iceberg/pull/9927#discussion_r1523221222
##########
core/src/test/java/org/apache/iceberg/TestMetadataUpdateParser.java:
##########
@@ -1158,20 +1142,13 @@ private static void assertEqualsSetStatistics(
BlobMetadata expectedBlob = pair.first();
BlobMetadata actualBlob = pair.second();
- Assert.assertEquals(
- "Expected blob type should be equal", expectedBlob.type(),
actualBlob.type());
- Assert.assertEquals(
- "Expected blob fields should be equal",
- expectedBlob.fields(),
- actualBlob.fields());
- Assert.assertEquals(
- "Expected blob source snapshot ID should be equal",
- expectedBlob.sourceSnapshotId(),
- actualBlob.sourceSnapshotId());
- Assert.assertEquals(
- "Expected blob source snapshot sequence number should be
equal",
- expectedBlob.sourceSnapshotSequenceNumber(),
- actualBlob.sourceSnapshotSequenceNumber());
+ assertThat(actualBlob.type()).isEqualTo(expectedBlob.type());
+ assertThat(actualBlob.fields()).isEqualTo(expectedBlob.fields());
+
assertThat(actualBlob.sourceSnapshotId()).isEqualTo(expectedBlob.sourceSnapshotId());
+ assertThat(actualBlob.sourceSnapshotSequenceNumber())
+ .isEqualTo(expectedBlob.sourceSnapshotSequenceNumber());
+ // assertThat(actualBlob.properties()).containsEntry()
+ System.out.println(expectedBlob.properties());
Review Comment:
should be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
