nastra commented on code in PR #9927:
URL: https://github.com/apache/iceberg/pull/9927#discussion_r1521054509
##########
core/src/test/java/org/apache/iceberg/TableMetadataParserTest.java:
##########
@@ -70,24 +67,30 @@ public void testCompressionProperty() throws IOException {
String location = "file://tmp/db/table";
TableMetadata metadata = newTableMetadata(SCHEMA, unpartitioned(),
location, properties);
TableMetadataParser.write(metadata, outputFile);
- Assert.assertEquals(codec == Codec.GZIP, isCompressed(fileName));
+ assertThat(isCompressed(fileName)).isEqualTo(codec == Codec.GZIP);
TableMetadata actualMetadata =
TableMetadataParser.read((FileIO) null, Files.localInput(new
File(fileName)));
verifyMetadata(metadata, actualMetadata);
}
- @After
+ @AfterEach
public void cleanup() throws IOException {
Codec codec = Codec.fromName(codecName);
Path metadataFilePath = Paths.get("v3" + getFileExtension(codec));
java.nio.file.Files.deleteIfExists(metadataFilePath);
}
private void verifyMetadata(TableMetadata expected, TableMetadata actual) {
- Assert.assertEquals(expected.schema().asStruct(),
actual.schema().asStruct());
- Assert.assertEquals(expected.location(), actual.location());
- Assert.assertEquals(expected.lastColumnId(), actual.lastColumnId());
- Assert.assertEquals(expected.properties(), actual.properties());
+
assertThat(actual.schema().asStruct()).isEqualTo(expected.schema().asStruct());
+ assertThat(actual.location()).isEqualTo(expected.location());
+ assertThat(actual.lastColumnId()).isEqualTo(expected.lastColumnId());
+ assertThat(actual.properties())
Review Comment:
why can't we use
`assertThat(actual.properties()).isEqualTo(expected.properties())` here? since
that's what the previous code was doing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
