nastra commented on code in PR #9927:
URL: https://github.com/apache/iceberg/pull/9927#discussion_r1523220281
##########
core/src/test/java/org/apache/iceberg/TestMetadataUpdateParser.java:
##########
@@ -1121,33 +1117,21 @@ private static void assertEqualsAddSortOrder(
private static void assertEqualsSetDefaultSortOrder(
MetadataUpdate.SetDefaultSortOrder expected,
MetadataUpdate.SetDefaultSortOrder actual) {
- Assert.assertEquals(
- "Sort order id should be the same", expected.sortOrderId(),
actual.sortOrderId());
+ assertThat(actual.sortOrderId()).isEqualTo(expected.sortOrderId());
}
private static void assertEqualsSetStatistics(
MetadataUpdate.SetStatistics expected, MetadataUpdate.SetStatistics
actual) {
- Assert.assertEquals("Snapshot IDs should be equal", expected.snapshotId(),
actual.snapshotId());
- Assert.assertEquals(
- "Statistics files snapshot IDs should be equal",
- expected.statisticsFile().snapshotId(),
- actual.statisticsFile().snapshotId());
- Assert.assertEquals(
- "Statistics files paths should be equal",
- expected.statisticsFile().path(),
- actual.statisticsFile().path());
- Assert.assertEquals(
- "Statistics files size should be equal",
- expected.statisticsFile().fileSizeInBytes(),
- actual.statisticsFile().fileSizeInBytes());
- Assert.assertEquals(
- "Statistics files footer size should be equal",
- expected.statisticsFile().fileFooterSizeInBytes(),
- actual.statisticsFile().fileFooterSizeInBytes());
- Assert.assertEquals(
- "Statistics blob list size should be equal",
- expected.statisticsFile().blobMetadata().size(),
- actual.statisticsFile().blobMetadata().size());
+ assertThat(actual.snapshotId()).isEqualTo(expected.snapshotId());
+ assertThat(actual.statisticsFile().snapshotId())
+ .isEqualTo(expected.statisticsFile().snapshotId());
+
assertThat(actual.statisticsFile().path()).isEqualTo(expected.statisticsFile().path());
+ assertThat(actual.statisticsFile().fileSizeInBytes())
+ .isEqualTo(expected.statisticsFile().fileSizeInBytes());
+ assertThat(actual.statisticsFile().fileFooterSizeInBytes())
+ .isEqualTo(expected.statisticsFile().fileFooterSizeInBytes());
+ assertThat(actual.statisticsFile().blobMetadata())
+ .hasSize(expected.statisticsFile().blobMetadata().size());
Review Comment:
this should probably use `.hasSameSizeAs(expected...blobMetadata())`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
