nastra commented on code in PR #9927:
URL: https://github.com/apache/iceberg/pull/9927#discussion_r1523217221
##########
core/src/test/java/org/apache/iceberg/TestMetadataUpdateParser.java:
##########
@@ -1036,43 +1038,39 @@ public void assertEquals(
private static void assertEqualsAssignUUID(
MetadataUpdate.AssignUUID expected, MetadataUpdate.AssignUUID actual) {
- Assert.assertEquals("UUIDs should be equal", expected.uuid(),
actual.uuid());
+ assertThat(actual.uuid()).isEqualTo(expected.uuid());
}
private static void assertEqualsUpgradeFormatVersion(
MetadataUpdate.UpgradeFormatVersion expected,
MetadataUpdate.UpgradeFormatVersion actual) {
- Assert.assertEquals(
- "Format version should be equal", expected.formatVersion(),
actual.formatVersion());
+ assertThat(actual.formatVersion()).isEqualTo(expected.formatVersion());
Review Comment:
we don't want to add a description just for the sake of having a
description. A description should only exist if we don't have enough contextual
information in the assertion. AssertJ typically will provide already enough
contextual information if assertions are used appropriately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
