szehon-ho commented on PR #9682: URL: https://github.com/apache/iceberg/pull/9682#issuecomment-1984689230
Thanks, i commented on the other thread in https://github.com/apache/iceberg/pull/9852#discussion_r1516373990 the original reason (saw that one first) Can you clarify this concern? > Additionally, this abstraction can actually hide errors, where we check for certain table properties by providing BaseMetadata. These properties don't exist for views, so what will happen if we check TableProperties.ENGINE_HIVE_ENABLED on a table and on view? This is just a class hiearchy. The view now gets methods like String property(String property, String defaultValue), which is just shorthand for viewMetadata.getProperties().getOrDefault(property, defaultValue). Strictly speaking, its not necssary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
