nastra commented on PR #9682: URL: https://github.com/apache/iceberg/pull/9682#issuecomment-1983818939
I reviewed https://github.com/apache/iceberg/pull/9852/ and also took a look at the metadata abstraction but I'm not convinced it actually makes stuff easier. Most of the time certain Hive methods only require 1-2 params (properties, schema, ...) from table/view metadata, so passing those directly makes more sense. Additionally, this abstraction can actually hide errors, where we check for certain table properties by providing `BaseMetadata`. These properties don't exist for views, so what will happen if we check `TableProperties.ENGINE_HIVE_ENABLED` on a table and on view? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
