nastra commented on code in PR #9620:
URL: https://github.com/apache/iceberg/pull/9620#discussion_r1486073880
##########
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##########
@@ -450,6 +452,15 @@ public ViewMetadata build() {
ViewProperties.VERSION_HISTORY_SIZE,
historySize);
+ if (!PropertyUtil.propertyAsBoolean(
+ properties,
+ ViewProperties.REPLACE_DROP_DIALECT_ALLOWED,
+ ViewProperties.REPLACE_DROP_DIALECT_ALLOWED_DEFAULT)) {
+ for (int i = Math.max(1, startingViewVersionsSize); i <
versions.size(); i++) {
+ checkIfDialectIsDropped(versions.get(i - 1), versions.get(i));
Review Comment:
indeed this was a bad assumption on my end. We need to check against the
view versions that have been added by the client, which I've changed now and
also added a test so that things fail correctly when the view version id is
being set by the client
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
