sdd commented on code in PR #207:
URL: https://github.com/apache/iceberg-rust/pull/207#discussion_r1507143315
##########
crates/iceberg/src/scan.rs:
##########
@@ -163,6 +178,54 @@ impl TableScan {
Ok(iter(file_scan_tasks).boxed())
}
+
+ /// Transforms a stream of FileScanTasks from plan_files into a stream of
+ /// Arrow RecordBatches.
+ pub fn open(&self, mut tasks: FileScanTaskStream) ->
crate::Result<ArrowRecordBatchStream> {
Review Comment:
> Putting `open` in `TableScan` seems weird to me. The `TableScan` has two
responsibilities: generate the task and open the task and it will make it
complex. Can we separate it out to the type, e.g. xxReader.🤔
Sure, I can do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
