zachdisc commented on code in PR #9731:
URL: https://github.com/apache/iceberg/pull/9731#discussion_r1498403869
##########
api/src/main/java/org/apache/iceberg/actions/RewriteManifests.java:
##########
@@ -44,6 +45,16 @@ public interface RewriteManifests
*/
RewriteManifests rewriteIf(Predicate<ManifestFile> predicate);
+ /**
+ * Rewrite manifests in a given order, based on partition columns
+ *
+ * <p>If not set, manifests will be rewritten in the order of the table's
spec.
+ *
+ * @param partitionSortOrder a list of partition field names
Review Comment:
Clarifying on the signature you're suggesting
```
RewriteManifests sort(Function<PartitionData, String>
partitionFieldsSortStrategy) {
throw new UnsupportedOperationException();
}
```
I would propose to have the method operate over a `DataFile`, so that all
attributes are available for scrutiny if the user wants, not just the partition
information itself.
```
RewriteManifests sort(Function<DataFile, String>
partitionFieldsSortStrategy) {
throw new UnsupportedOperationException();
}
```
So the specific implementation would be a `SparkDataFile` I think, and need
to do the same kind of `toDataFile` converter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
