nastra commented on code in PR #9731:
URL: https://github.com/apache/iceberg/pull/9731#discussion_r1497892858
##########
.palantir/revapi.yml:
##########
@@ -873,6 +873,10 @@ acceptedBreaks:
new: "method void org.apache.iceberg.encryption.Ciphers::<init>()"
justification: "Static utility class - should not have public
constructor"
"1.4.0":
+ org.apache.iceberg:iceberg-api:
Review Comment:
we haven't updated revapi to 1.5.0 yet because 1.5.0 hasn't been released
yet.
On another note: this PR should not introduce breaking API changes by adding
a new method. There should be a default implementation that throws an
`UnsupportedOperationException` (see
https://github.com/apache/iceberg/blob/main/CONTRIBUTING.md#adding-a-default-implementation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
