jackye1995 commented on code in PR #9731:
URL: https://github.com/apache/iceberg/pull/9731#discussion_r1498282727
##########
api/src/main/java/org/apache/iceberg/actions/RewriteManifests.java:
##########
@@ -44,6 +45,16 @@ public interface RewriteManifests
*/
RewriteManifests rewriteIf(Predicate<ManifestFile> predicate);
+ /**
+ * Rewrite manifests in a given order, based on partition columns
+ *
+ * <p>If not set, manifests will be rewritten in the order of the table's
spec.
+ *
+ * @param partitionSortOrder a list of partition field names
Review Comment:
My feeling is that if we merge this and you end up having to refactor it a
lot, then it is better for everyone to help you make the right changes here.
But I am all for incremental changes, so if we can agree that the
function-based API proposed in the original issue can be added through
refactoring later, then I am totally good with that! Let's see what others
think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
