jackye1995 commented on code in PR #9731: URL: https://github.com/apache/iceberg/pull/9731#discussion_r1500217705
########## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java: ########## @@ -90,13 +94,13 @@ public class RewriteManifestsSparkAction public static final String USE_CACHING = "use-caching"; public static final boolean USE_CACHING_DEFAULT = false; + private List<String> partitionSortColumns = null; Review Comment: nit: we follow `public static final` -> `private static final` -> `private final` -> `private` to order variables -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
