zachdisc commented on PR #9731: URL: https://github.com/apache/iceberg/pull/9731#issuecomment-1960639662
> Looks like the CI test failed, @zachdisc could you take a look and fix? > > Overall, we have the 2 options based on this thread: [#9731 (comment)](https://github.com/apache/iceberg/pull/9731#discussion_r1494774386) > > option 1: we merge this and have a subsequent PR for the functional API and refactor the current change into it option 2: we directly update the current PR to go with that approach > > Is there any preference for which way we go? I'm not quite sure why that failed, I ran spotlessApply and saw a successful build locally before the last push. Regardless, I have two changes inbound, so I'll fix along with the new updates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
