rahil-c commented on code in PR #9660:
URL: https://github.com/apache/iceberg/pull/9660#discussion_r1488452604
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1482,6 +1490,34 @@ components:
explode: false
example: "vended-credentials,remote-signing"
+ page-token:
+ name: pageToken
+ in: query
+ description:
+ An opaque token which allows clients to make use of pagination by
signaling to the service that they would
+ prefer requests to be paginated based on the number of items specified
by pageSize.
+
+ Clients that support pagination initiate the request by sending an
empty pageToken e.g. GET /tables?pageToken
Review Comment:
Thanks for suggestion, If we are telling users to provide an empty token
then why would pick option 3 where we are setting a value? I think option 1 or
2 makes sense to me.
For option 1 i think the presence alone of pageToken without a value should
be something that services can check, and seems straightforward to me.
For option 2 if the value is just the empty string `""` that is also fine
but seems a little akward for clients to have to set that.
cc @jackye1995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
