jackye1995 commented on code in PR #9660:
URL: https://github.com/apache/iceberg/pull/9660#discussion_r1488490615


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1482,6 +1490,34 @@ components:
       explode: false
       example: "vended-credentials,remote-signing"
 
+    page-token:
+      name: pageToken
+      in: query
+      description:
+        An opaque token which allows clients to make use of pagination by 
signaling to the service that they would
+        prefer requests to be paginated based on the number of items specified 
by pageSize.
+        
+        Clients that support pagination initiate the request by sending an 
empty pageToken e.g. GET /tables?pageToken

Review Comment:
   My only concern with option 1 and 2 is that it seems to be something not 
universally supported. But I might be wrong. If we agree upon an empty value 
that is not an empty string, then any query parameter parser only needs to 
understand `key1=value1&key2=value2&...` syntax for query parameter, that's the 
most conservative approach to me. Curious what others think.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to