rdblue commented on code in PR #9582:
URL: https://github.com/apache/iceberg/pull/9582#discussion_r1473170465
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java:
##########
@@ -1362,6 +1362,127 @@ public void showCreateComplexView() {
assertThat(sql("SHOW CREATE TABLE %s",
viewName)).containsExactly(row(expected));
}
+ @Test
+ public void alterViewSetProperties() {
+ String viewName = "viewWithSetProperties";
+
+ sql("CREATE VIEW %s AS SELECT id FROM %s WHERE id <= 3", viewName,
tableName);
+
+ ViewCatalog viewCatalog = viewCatalog();
+ assertThat(viewCatalog.loadView(TableIdentifier.of(NAMESPACE,
viewName)).properties())
+ .doesNotContainKey("key1")
+ .doesNotContainKey("comment");
+
+ sql("ALTER VIEW %s SET TBLPROPERTIES ('key1' = 'val1', 'comment' = 'view
comment')", viewName);
+ assertThat(viewCatalog.loadView(TableIdentifier.of(NAMESPACE,
viewName)).properties())
+ .containsEntry("key1", "val1")
+ .containsEntry("comment", "view comment");
+
+ sql("ALTER VIEW %s SET TBLPROPERTIES ('key1' = 'new_val1')", viewName);
+ assertThat(viewCatalog.loadView(TableIdentifier.of(NAMESPACE,
viewName)).properties())
+ .containsEntry("key1", "new_val1")
+ .containsEntry("comment", "view comment");
+ }
+
+ @Test
+ public void alterViewSetReservedProperties() {
+ String viewName = "viewWithSetReservedProperties";
+
+ sql("CREATE VIEW %s AS SELECT id FROM %s WHERE id <= 3", viewName,
tableName);
+
+ assertThatThrownBy(() -> sql("ALTER VIEW %s SET TBLPROPERTIES ('provider'
= 'val1')", viewName))
+ .isInstanceOf(AnalysisException.class)
+ .hasMessageContaining(
+ "The feature is not supported: provider is a reserved table
property");
+
+ assertThatThrownBy(
+ () -> sql("ALTER VIEW %s SET TBLPROPERTIES ('location' =
'random_location')", viewName))
+ .isInstanceOf(AnalysisException.class)
+ .hasMessageContaining(
+ "The feature is not supported: location is a reserved table
property");
Review Comment:
Nit: Just because Spark has a bad error message doesn't mean Iceberg should.
We could make this conform to our standard, which is more clear: `"Cannot set
reserved property: location"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
