rdblue commented on code in PR #9582: URL: https://github.com/apache/iceberg/pull/9582#discussion_r1471693576
########## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ########## @@ -60,17 +62,18 @@ case class RewriteViewCommands(spark: SparkSession) extends Rule[LogicalPlan] wi properties = properties, allowExisting = allowExisting, replace = replace) + + case u@UnresolvedView(ResolvedView(resolved), _, _, _) => Review Comment: Why does this need to be done here instead of in `ResolveViews`? This is just resolving the view. I think it's probably that we have to resolve early to avoid an `AnalysisException`, but it would be great to clarify with a comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org