nastra commented on code in PR #9582:
URL: https://github.com/apache/iceberg/pull/9582#discussion_r1472648183
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -606,6 +607,29 @@ public View createView(
@Override
public View alterView(Identifier ident, ViewChange... changes)
throws NoSuchViewException, IllegalArgumentException {
+ if (null != asViewCatalog) {
+ try {
+ org.apache.iceberg.view.View view =
asViewCatalog.loadView(buildIdentifier(ident));
+ UpdateViewProperties updateViewProperties = view.updateProperties();
Review Comment:
this is a miss on my end. For some reason reason I manually checked
`provider` / `location` (which Spark would prevent from being set/unset) and
assumed Spark would do this for all reserved properties.
I've added some tests and fixed this. Note that I'm rejecting both
setting/removing reserved properties as it seems a bit confusing from a user's
perspective if Spark rejects setting/removing certain properties but we only
reject setting those.
It also appears that the behavior for tables is slightly different, where
we're only rejecting setting reserved table properties, but we're not
rejecting the removal of reserved table properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
