rdblue commented on code in PR #9582:
URL: https://github.com/apache/iceberg/pull/9582#discussion_r1471699613
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -606,6 +607,29 @@ public View createView(
@Override
public View alterView(Identifier ident, ViewChange... changes)
throws NoSuchViewException, IllegalArgumentException {
+ if (null != asViewCatalog) {
+ try {
+ org.apache.iceberg.view.View view =
asViewCatalog.loadView(buildIdentifier(ident));
+ UpdateViewProperties updateViewProperties = view.updateProperties();
Review Comment:
Can you also reject reserved properties? I don't think that you should be
able to set `format-version`, `location`, or `provider`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
