rdblue commented on code in PR #9582:
URL: https://github.com/apache/iceberg/pull/9582#discussion_r1473175246
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java:
##########
@@ -36,7 +36,7 @@
public class SparkView implements org.apache.spark.sql.connector.catalog.View {
private static final String QUERY_COLUMN_NAMES = "queryColumnNames";
Review Comment:
Is this our property name? We never use camelCase for Iceberg properties. I
think this should be `query-column-names` and should possibly have a prefix,
like `spark.query-column-names`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
