nastra commented on code in PR #9342:
URL: https://github.com/apache/iceberg/pull/9342#discussion_r1432341279
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestStreamingOffset.java:
##########
@@ -35,10 +36,10 @@ public void testJsonConversion() {
new StreamingOffset(System.currentTimeMillis(), 3L, false),
new StreamingOffset(System.currentTimeMillis(), 4L, true)
};
- Assert.assertArrayEquals(
- "StreamingOffsets should match",
- expected,
- Arrays.stream(expected).map(elem ->
StreamingOffset.fromJson(elem.json())).toArray());
+ assertThat(expected)
Review Comment:
same here
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestStreamingOffset.java:
##########
@@ -51,6 +52,6 @@ public void testToJson() throws Exception {
actual.put("scan_all_files", false);
String expectedJson = expected.json();
String actualJson = JsonUtil.mapper().writeValueAsString(actual);
- Assert.assertEquals("Json should match", expectedJson, actualJson);
+ assertThat(expectedJson).isEqualTo(actualJson);
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
