chinmay-bhat commented on code in PR #9342:
URL: https://github.com/apache/iceberg/pull/9342#discussion_r1432347207
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkReadProjection.java:
##########
@@ -110,7 +110,7 @@ public static void stopSpark() {
@Override
protected Record writeAndRead(String desc, Schema writeSchema, Schema
readSchema, Record record)
throws IOException {
- File parent = temp.newFolder(desc);
+ File parent = temp.resolve(desc).toFile();
Review Comment:
I wanted to create a PR with only non-paramterized changes. This file was
using the tempDir from its base class, which was now a JUnit5 implementation.
So I only made this small change. The changes with parameterizing annotations
would be in another PR.
Or is it ok to do it all in 1 PR? That might make the PR hard to review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
