chinmay-bhat commented on PR #9342: URL: https://github.com/apache/iceberg/pull/9342#issuecomment-1864173459
Also, file [TestInternalRowWrapper](https://github.com/apache/iceberg/blob/main/spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestInternalRowWrapper.java) extends [RecordWrapperTest](https://github.com/apache/iceberg/blob/main/data/src/test/java/org/apache/iceberg/RecordWrapperTest.java). RecordWrapperTest is also used by `iceberg-flink` and uses JUnit4. Do we need to make a copy of RecordWrapperTest in JUnit5 to migrate TestInternalRowWrapper? The copy and original RecordWrapperTest will be available at the same time. Maybe in another PR? I haven't added my changes to TestInternalRowWrapper to this PR for that reason. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
