nastra commented on code in PR #9342:
URL: https://github.com/apache/iceberg/pull/9342#discussion_r1432334842
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSpark.java:
##########
@@ -59,83 +60,78 @@ public static void stopSpark() {
public void testRegisterIntegerBucketUDF() {
IcebergSpark.registerBucketUDF(spark, "iceberg_bucket_int_16",
DataTypes.IntegerType, 16);
List<Row> results = spark.sql("SELECT
iceberg_bucket_int_16(1)").collectAsList();
- Assert.assertEquals(1, results.size());
- Assert.assertEquals(
- (int) Transforms.bucket(16).bind(Types.IntegerType.get()).apply(1),
- results.get(0).getInt(0));
+
+ assertThat(results).hasSize(1);
+ assertThat((int)
Transforms.bucket(16).bind(Types.IntegerType.get()).apply(1))
Review Comment:
it looks like in this file the expected/actual is the other way around
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
