chinmay-bhat commented on code in PR #9342: URL: https://github.com/apache/iceberg/pull/9342#discussion_r1432169104
########## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestAvroScan.java: ########## @@ -41,25 +43,24 @@ import org.apache.spark.sql.Dataset; import org.apache.spark.sql.Row; import org.apache.spark.sql.SparkSession; -import org.junit.AfterClass; -import org.junit.Assert; -import org.junit.BeforeClass; -import org.junit.Rule; -import org.junit.rules.TemporaryFolder; +import org.junit.jupiter.api.AfterAll; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.io.TempDir; public class TestAvroScan extends AvroDataTest { private static final Configuration CONF = new Configuration(); - @Rule public TemporaryFolder temp = new TemporaryFolder(); + @TempDir + public Path temp; Review Comment: updated ########## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestBaseReader.java: ########## @@ -47,14 +49,13 @@ import org.apache.iceberg.relocated.com.google.common.collect.Maps; import org.apache.iceberg.spark.data.RandomData; import org.apache.iceberg.types.Types; -import org.junit.Assert; -import org.junit.Rule; -import org.junit.Test; -import org.junit.rules.TemporaryFolder; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.io.TempDir; public class TestBaseReader { - @Rule public TemporaryFolder temp = new TemporaryFolder(); + @TempDir + public Path temp; Review Comment: updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org