nk1506 commented on code in PR #8907:
URL: https://github.com/apache/iceberg/pull/8907#discussion_r1414960618
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -264,6 +269,162 @@ public void renameTable(TableIdentifier from,
TableIdentifier originalTo) {
}
}
+ @Override
+ public boolean viewExists(TableIdentifier identifier) {
+ return HiveCatalogUtil.isTableWithTypeExists(clients, identifier,
TableType.VIRTUAL_VIEW);
Review Comment:
I think we started this
[discussion](https://github.com/apache/iceberg/issues/8698#issuecomment-1770264064)
but never came to any conclusion . I had only one concerns for adding it as
property for backward-compatibility.
There must be a check at all the places with table property whether it is as
Iceberg-table or iceberg-view. We do validate with
[validateTableIsIceberg](https://github.com/apache/iceberg/blob/99843f03efecc3f5ef7d3e1d32aae5eff22cb315/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java#L96)
for table. Please suggest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
