barronw commented on issue #72:
URL: https://github.com/apache/iceberg-rust/issues/72#issuecomment-1751731013
Thanks for the feedback folks! How do we feel about something like this?
```rust
struct ManifestListWriter {
output_file: OutputFile,
format_version: FormatVersion,
avro_schema: AvroSchema,
metadata: HashMap<String, String>,
}
impl ManifestListWriter {
pub fn new(
output_file: OutputFile,
format_version: FormatVersion,
metadata: HashMap<String, String>,
) -> ManifestListWriter {
let schema = match format_version {
FormatVersion::V1 => ManifestList::v1_schema(),
FormatVersion::V2 => ManifestList::v2_schema(),
};
let avro_schema = schema_to_avro_schema("manifest_list",
&schema).unwrap();
Self {
output_file,
format_version,
avro_schema,
metadata,
}
}
async fn write(self, manifest_list: ManifestList) {
...
}
}
```
Should we support appending entries like the Java and Python implementations
instead of a single write?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
