liurenjie1024 commented on issue #72:
URL: https://github.com/apache/iceberg-rust/issues/72#issuecomment-1751583913
> Thanks! We can integrate V1 and V2 into a writer
>
> ```
> struck ManifestListWriter {
> ...
> }
>
> impl ManifestListWriter {
> fn write_v1(&mut self, manifest_list: ManifestList) {
> }
>
> fn write_v2(&mut self, manifest_list: ManifestList) {
> }
> }
> ```
>
> And we can store the version in ManifestList so that we can just use
`write(&mut self manifest_list: ManifestList)`.
LGTM. The key difference between between v1 and v2 are the avro schema,
which should be determinted in constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
