barronw opened a new issue, #72:
URL: https://github.com/apache/iceberg-rust/issues/72

   Hi! I'd like to review a design for a manifest list writer before 
implementation. The design is based on Icelake and PyIceberg.
   
   ```rust
   struct ManifestListWriterV1 {
       output_file: OutputFile,
       snapshot_id: i64,
       parent_snapshot_id: i64,
   }
   
   impl ManifestListWriterV1 {
       fn new(output_file: OutputFile, snapshot_id: i64, parent_snapshot_id: 
i64) -> ManifestListWriterV1 {
           ...
       }
   
       async fn write(self, manifest_list: ManifestListV1) -> Result<()> {
           ...
       }
   }
   
   struct ManifestListWriterV2 {
       output_file: OutputFile,
       snapshot_id: i64,
       parent_snapshot_id: i64,
       sequence_number: i64,
   }
   
   impl ManifestListWriterV2 {
       fn new(output_file: OutputFile, snapshot_id: i64, parent_snapshot_id: 
i64, sequence_number: i64) -> ManifestListWriterV2 {
           ...
       }
   
       async fn write(self, manifest_list: ManifestListV2) -> Result<()> {
           ...
       }
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to