liurenjie1024 commented on issue #72:
URL: https://github.com/apache/iceberg-rust/issues/72#issuecomment-1754168678
> > The ManifestList is a simple wrapper of Vec, so I think providing a
method for iterator of entries would not be huge effort.
>
> I'm not sure I'm following. To clarify, I was wondering if we should have
something like
>
> ```rust
> struct ManifestListWriter {
> ...,
> writer: apache_avro::Writer,
> }
>
> impl ManifestListWriter {
> fn append(entries: ManifestList) {
> // Append entries to Avro writer
> }
>
> fn close() {
> // Close Avro writer
> }
> }
> ```
>
> This is a bit complex though, since the [Avro
writer](https://docs.rs/apache-avro/latest/apache_avro/struct.Writer.html) has
a reference to the Avro schema.
I don't think we should have this, the java writer appends `ManifestFile`,
e.g. `ManifestListEntry`.
I was saying we should have sth like:
```rust
impl ManifestListWriter {
fn append(&mut self, entries: impl Iterator<Item=ManifestListEntry>>) {
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
