[ https://issues.apache.org/jira/browse/GEODE-8119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17119479#comment-17119479 ]
ASF GitHub Bot commented on GEODE-8119: --------------------------------------- mkevo commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-635901434 > Hey @mkevo > Thanks for working on this, I'll start the review once all `CI` tests are green. > Cheers. It looks that last five opened PRs failed on LGTM check. ``` [2020-05-29 00:08:56] [analysis] [EVALUATION 115/177] [FAIL] Error running query semmlecode-queries/Security/CWE/CWE-022/TaintedPath.ql: OutOfMemory Query evaluation ran out of memory (maximum allowed memory: 3012MB). ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Threads are not properly closed when offline disk-store commands are invoked > ---------------------------------------------------------------------------- > > Key: GEODE-8119 > URL: https://issues.apache.org/jira/browse/GEODE-8119 > Project: Geode > Issue Type: Bug > Components: gfsh > Reporter: Mario Kevo > Assignee: Mario Kevo > Priority: Major > > Threads can be opened when you are online and offline, but close only when > you are online. Once some offline command started thread it cannot be closed > and after some time if there is a bigger number of this threads it can lead > to OOM exception. > Also the problem is that its validating only disk-dirs but not diskStore > name. So thread can be created but there is no diskStore with that name and > it will also hang. -- This message was sent by Atlassian Jira (v8.3.4#803005)