[ 
https://issues.apache.org/jira/browse/GEODE-8119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118442#comment-17118442
 ] 

ASF GitHub Bot commented on GEODE-8119:
---------------------------------------

mkevo commented on pull request #5167:
URL: https://github.com/apache/geode/pull/5167#issuecomment-635198597


   I tried to run it and it failed with:
   ```
   [Could not find: "/tmp/junit5454972723589376526/diskDir2/BACKUPtestDisk.if, 
/tmp/junit5454972723589376526/diskDir3/BACKUPtestDisk.if"
   ] expected:<[OK]> but was:<[ERROR]>
   ```
   
   Also I tried to run it locally on the gfsh(without my changes) and see that 
if you create disk-store with multiple dirs added it will create this .if file 
only in first dir, and when doing validate it can't found it in other dirs.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Threads are not properly closed when offline disk-store commands are invoked
> ----------------------------------------------------------------------------
>
>                 Key: GEODE-8119
>                 URL: https://issues.apache.org/jira/browse/GEODE-8119
>             Project: Geode
>          Issue Type: Bug
>          Components: gfsh
>            Reporter: Mario Kevo
>            Assignee: Mario Kevo
>            Priority: Major
>
> Threads can be opened when you are online and offline, but close only when 
> you are online. Once some offline command started thread it cannot be closed 
> and after some time if there is a bigger number of this threads it can lead 
> to OOM exception.
> Also the problem is that its validating only disk-dirs but not diskStore 
> name. So thread can be created but there is no diskStore with that name and 
> it will also hang.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to