[
https://issues.apache.org/jira/browse/GEODE-8119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123803#comment-17123803
]
ASF GitHub Bot commented on GEODE-8119:
---------------------------------------
jujoramos commented on pull request #5175:
URL: https://github.com/apache/geode/pull/5175#issuecomment-637555044
@mkevo
I don't see anything related to threads within the
`DiskStoreCommandsUtils.validatedDirectories()` method, it's just a regular
java method that executes sequentially and returns a `String` result; so I'm
not entirely sure about what you mean by _**When wrong name is provided, but
the thread is already started and not closed.**_
Maybe the problem is somewhere else, like the `gfsh` commands that use this
method?. (I recall fixing an issue related to non daemon threads launched by
`gfsh` command -> https://github.com/apache/geode/pull/5054).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Threads are not properly closed when offline disk-store commands are invoked
> ----------------------------------------------------------------------------
>
> Key: GEODE-8119
> URL: https://issues.apache.org/jira/browse/GEODE-8119
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Reporter: Mario Kevo
> Assignee: Mario Kevo
> Priority: Major
>
> Threads can be opened when you are online and offline, but close only when
> you are online. Once some offline command started thread it cannot be closed
> and after some time if there is a bigger number of this threads it can lead
> to OOM exception.
> Also the problem is that its validating only disk-dirs but not diskStore
> name. So thread can be created but there is no diskStore with that name and
> it will also hang.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
