[
https://issues.apache.org/jira/browse/GEODE-8119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117767#comment-17117767
]
Juan Ramos commented on GEODE-8119:
-----------------------------------
Hello [~mkevo],
I've been finally able to reproduce the issue using a {{DistributedTest}}. The
test basically makes sure that a member using a newer (current) version of
Geode can start up using a {{disk-store}} created using an older version
({{1.12.0}} in this case); it's basically a regular upgrade test scenario.
The test succeeds without your changes for {{GEODE-8119}}, and fails with the
following exception after merging the changes:
{noformat}
Command result for <validate offline-disk-store --name=testDisk
--disk-dirs=/var/folders/d7/r6jcs9m15q9_s_tfzy4tvbjm0000gn/T/junit853175387123885355/diskDir1,/var/folders/d7/r6jcs9m15q9_s_tfzy4tvbjm0000gn/T/junit853175387123885355/diskDir2,/var/folders/d7/r6jcs9m15q9_s_tfzy4tvbjm0000gn/T/junit853175387123885355/diskDir3>:
_________________________ __
/ _____/ ______/ ______/ /____/ /
/ / __/ /___ /_____ / _____ /
/ /__/ / ____/ _____/ / / / /
/______/_/ /______/_/ /_/ 1.14.0-build.0
Monitor and Manage Apache Geode
Could not find:
"/var/folders/d7/r6jcs9m15q9_s_tfzy4tvbjm0000gn/T/junit853175387123885355/diskDir2/BACKUPtestDisk.if,
/var/folders/d7/r6jcs9m15q9_s_tfzy4tvbjm0000gn/T/junit853175387123885355/diskDir3/BACKUPtestDisk.if"
{noformat}
I'm pretty sure the problem is related to the changes in
{{DiskStoreCommandsUtils.validatedDirectoriesAndFile}}. I've created a new
[{{draft PR}}|https://github.com/apache/geode/pull/5167] with your original
changes + the test to reproduce the regression, you can check it out and
troubleshoot the issue locally.
> Threads are not properly closed when offline disk-store commands are invoked
> ----------------------------------------------------------------------------
>
> Key: GEODE-8119
> URL: https://issues.apache.org/jira/browse/GEODE-8119
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Reporter: Mario Kevo
> Assignee: Mario Kevo
> Priority: Major
>
> Threads can be opened when you are online and offline, but close only when
> you are online. Once some offline command started thread it cannot be closed
> and after some time if there is a bigger number of this threads it can lead
> to OOM exception.
> Also the problem is that its validating only disk-dirs but not diskStore
> name. So thread can be created but there is no diskStore with that name and
> it will also hang.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
