[
https://issues.apache.org/jira/browse/GEODE-8119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124757#comment-17124757
]
ASF GitHub Bot commented on GEODE-8119:
---------------------------------------
mkevo commented on pull request #5175:
URL: https://github.com/apache/geode/pull/5175#issuecomment-638049210
@jujoramos
In all offline disk-store commands it calls DiskStoreImpl in which is
startAsyncFlusher which starts these threads. E.g.
_AlterOfflineDiskStoreCommand_ use _modifyRegion_ which have _createForOffline_
method in which _DiskStoreImpl_ constructor is called where it start this
thread with _startAsyncFlusher_.
But if set that it validate also name at the start, not only dirs it will
not be started.
Please see my latest changes and verify it with your tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Threads are not properly closed when offline disk-store commands are invoked
> ----------------------------------------------------------------------------
>
> Key: GEODE-8119
> URL: https://issues.apache.org/jira/browse/GEODE-8119
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Reporter: Mario Kevo
> Assignee: Mario Kevo
> Priority: Major
>
> Threads can be opened when you are online and offline, but close only when
> you are online. Once some offline command started thread it cannot be closed
> and after some time if there is a bigger number of this threads it can lead
> to OOM exception.
> Also the problem is that its validating only disk-dirs but not diskStore
> name. So thread can be created but there is no diskStore with that name and
> it will also hang.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
