Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: saving memcheck parameter to answer file
......................................................................
Patch Set 5:
(4 comments)
....................................................
File packaging/setup/ovirt_engine_setup/constants.py
Line 769: @osetupattrs(
Line 770: answerfile=True,
Line 771: )
Line 772: def MEMCHECK_ENABLED(self):
Line 773: return 'OVESETUP_SYSTEM/memCheckEnabled'
I almost sure you must have space here... run packaging/check
Line 774: MEMCHECK_MINIMUM_MB = 'OVESETUP_SYSTEM/memCheckMinimumMB'
Line 775: MEMCHECK_RECOMMENDED_MB = 'OVESETUP_SYSTEM/memCheckRecommendedMB'
Line 776:
Line 777: SELINUX_CONTEXTS = 'OVESETUP_SYSTEM/selinuxContexts'
....................................................
File packaging/setup/plugins/ovirt-engine-setup/system/memcheck.py
Line 140: if (
Line 141: not self._satisfied and
Line 142: self.environment[
Line 143: osetupcons.SystemEnv.MEMCHECK_ENABLED
Line 144: ]
please invert condition, first check enabled then satisfied.
Line 145: ):
Line 146: if not dialog.queryBoolean(
Line 147: dialog=self.dialog,
Line 148: name='OVESETUP_IGNORE_LOW_MEMORY',
Line 144: ]
Line 145: ):
Line 146: if not dialog.queryBoolean(
Line 147: dialog=self.dialog,
Line 148: name='OVESETUP_IGNORE_LOW_MEMORY',
revert?
Line 149: note=_(
Line 150: 'Do you want Setup to continue, with amount of
memory '
Line 151: 'less than recommended? (@VALUES@) [@DEFAULT@]: '
Line 152: ),
Line 155: false=_('No'),
Line 156: default=False,
Line 157: ):
Line 158: raise RuntimeError(_('Aborted by user'))
Line 159: else:
no need for else after raise
Line 160: self.environment[
Line 161: osetupcons.SystemEnv.MEMCHECK_ENABLED
Line 162: ] = False
Line 163:
--
To view, visit http://gerrit.ovirt.org/18669
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I351b129c396d34fb1def8a8ddd1180e21aeeab14
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
