Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: saving memcheck parameter to answer file ......................................................................
Patch Set 6: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/system/memcheck.py Line 111: Line 112: @plugin.event( Line 113: stage=plugin.Stages.STAGE_CUSTOMIZATION, Line 114: ) Line 115: def _checkMemory(self): hmmm... this should be in validation too... just saw that. Line 116: """ Line 117: Check if the system met the memory requirements. Line 118: """ Line 119: self.logger.debug('Checking total memory') -- To view, visit http://gerrit.ovirt.org/18669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I351b129c396d34fb1def8a8ddd1180e21aeeab14 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches