Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: saving memcheck parameter to answer file ......................................................................
Patch Set 6: (2 comments) .................................................... File packaging/setup/ovirt_engine_setup/constants.py Line 769: @osetupattrs( Line 770: answerfile=True, Line 771: ) Line 772: def MEMCHECK_ENABLED(self): Line 773: return 'OVESETUP_SYSTEM/memCheckEnabled' are you sure no empty line needed? example: ./packaging/setup/ovirt_engine_setup/constants.py:649:5: E301 expected 1 blank line, found 0 Line 774: MEMCHECK_MINIMUM_MB = 'OVESETUP_SYSTEM/memCheckMinimumMB' Line 775: MEMCHECK_RECOMMENDED_MB = 'OVESETUP_SYSTEM/memCheckRecommendedMB' Line 776: Line 777: SELINUX_CONTEXTS = 'OVESETUP_SYSTEM/selinuxContexts' .................................................... File packaging/setup/plugins/ovirt-engine-setup/system/memcheck.py Line 106: osetupcons.Defaults.DEFAULT_SYSTEM_MEMCHECK_RECOMMENDED_MB Line 107: ) Line 108: self._enabled = self.environment[ Line 109: osetupcons.SystemEnv.MEMCHECK_ENABLED Line 110: ] you do not need this enabled if you use it one time... Line 111: Line 112: @plugin.event( Line 113: stage=plugin.Stages.STAGE_CUSTOMIZATION, Line 114: ) -- To view, visit http://gerrit.ovirt.org/18669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I351b129c396d34fb1def8a8ddd1180e21aeeab14 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
