Maor Lipchuk has posted comments on this change.
Change subject: core: OvfManager - package and functionality
......................................................................
Patch Set 2: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfManager.java
Line 77: }
Line 78:
Line 79: public VM readVmFromOvf(String ovf) throws OvfReaderException{
Line 80: VM toReturn = new VM();
Line 81: ArrayList<DiskImage> diskImages = new ArrayList<DiskImage>();
You can use diamond operator here
Line 82: ArrayList<VmNetworkInterface> interfaces = new
ArrayList<VmNetworkInterface>();
Line 83: ImportVm(ovf, toReturn, diskImages, interfaces);
Line 84:
Line 85: // add images
Line 78:
Line 79: public VM readVmFromOvf(String ovf) throws OvfReaderException{
Line 80: VM toReturn = new VM();
Line 81: ArrayList<DiskImage> diskImages = new ArrayList<DiskImage>();
Line 82: ArrayList<VmNetworkInterface> interfaces = new
ArrayList<VmNetworkInterface>();
same here
Line 83: ImportVm(ovf, toReturn, diskImages, interfaces);
Line 84:
Line 85: // add images
Line 86: toReturn.setImages(diskImages);
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
Line 33: import java.util.Collections;
Line 34: import java.util.Iterator;
Line 35: import java.util.LinkedList;
Line 36: import java.util.List;
Line 37: import java.util.Map;
The imports should not be changed.
Line 38:
Line 39: /**
Line 40: * This command responsible to removing image, contains all created
snapshots.
Line 41: */
Line 289:
getParameters().getStorageDomainId()));
Line 290: unLockImage();
Line 291: return null;
Line 292: }
Line 293: });
Any reason this line was change?
Line 294: }
Line 295:
Line 296: private void performImageDbOperations() {
Line 297: switch (getParameters().getDbOperationScope()) {
--
To view, visit http://gerrit.ovirt.org/15626
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bfc4094178d90e7b0583db4e427fc2b195a367d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
