Arik Hadas has posted comments on this change. Change subject: core: OvfManager - package and functionality ......................................................................
Patch Set 4: @Liron As you can see, in this patch i also wanted export the logic of "assembling" the "rest" of the vm to the ovf manager. I see, IMO the solution is somewhere in the middle: the existing implementation of ovf manager is kind of "facade" for the underlying ovf mechanism and should reside in the util project. the code you add in this patch should not be added to OvfManager, but to other class in bll project. -- To view, visit http://gerrit.ovirt.org/15626 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bfc4094178d90e7b0583db4e427fc2b195a367d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
