Liron Ar has posted comments on this change.
Change subject: core: OvfManager - package and functionality
......................................................................
Patch Set 2: (2 inline comments)
@Allon - Thought about it, but i have debates regards the reader/writer as they
are more general utils that "knows" to parse ovirt ovf file. the manager just
executes them and adds bll logic.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfManager.java
Line 88: toReturn.setInterfaces(interfaces);
Line 89:
Line 90: // add disk map
Line 91: Map<Guid, List<DiskImage>> images = ImagesHandler
Line 92: .getImagesLeaf(diskImages);
same
Line 93: for (Guid id : images.keySet()) {
Line 94: List<DiskImage> list = images.get(id);
Line 95: toReturn.getDiskMap().put(id, list.get(list.size() - 1));
Line 96: }
Line 89:
Line 90: // add disk map
Line 91: Map<Guid, List<DiskImage>> images = ImagesHandler
Line 92: .getImagesLeaf(diskImages);
Line 93: for (Guid id : images.keySet()) {
in this patch i just moved the logic as stated in the commit message -
copy/paste :-) so it could be used in other places as well . I prefer to change
the logic in a different patch...this patch is "dummy"
Line 94: List<DiskImage> list = images.get(id);
Line 95: toReturn.getDiskMap().put(id, list.get(list.size() - 1));
Line 96: }
Line 97:
--
To view, visit http://gerrit.ovirt.org/15626
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bfc4094178d90e7b0583db4e427fc2b195a367d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
