Arik Hadas has posted comments on this change.
Change subject: core: OvfManager - package and functionality
......................................................................
Patch Set 4: (2 inline comments)
guys, can you please explain what is the "bll logic" in OvfManager you're
referring to? is it anything else besides setting the VM id for each interface?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfManager.java
Line 89:
Line 90: // add disk map
Line 91: Map<Guid, List<DiskImage>> images = ImagesHandler
Line 92: .getImagesLeaf(diskImages);
Line 93: for (Guid id : images.keySet()) {
this code was copied from GetVmsFromExportDomainQuery right? it was iterating
through entrySet() there, why changing that?
Line 94: List<DiskImage> list = images.get(id);
Line 95: toReturn.getDiskMap().put(id, list.get(list.size() - 1));
Line 96: }
Line 97:
Line 91: Map<Guid, List<DiskImage>> images = ImagesHandler
Line 92: .getImagesLeaf(diskImages);
Line 93: for (Guid id : images.keySet()) {
Line 94: List<DiskImage> list = images.get(id);
Line 95: toReturn.getDiskMap().put(id, list.get(list.size() - 1));
I know it was that way before, but is it possible that the returned list (line
94) be empty? because if so, there might get an exception when trying to get
the element at index list.size()-1. it can be made in a different patch if you
want to keep this one simple though
Line 96: }
Line 97:
Line 98: return toReturn;
Line 99: }
--
To view, visit http://gerrit.ovirt.org/15626
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bfc4094178d90e7b0583db4e427fc2b195a367d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
