Arik Hadas has posted comments on this change.

Change subject: core: OvfManager - package and functionality
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfManager.java
Line 91:         Map<Guid, List<DiskImage>> images = ImagesHandler
Line 92:                 .getImagesLeaf(diskImages);
Line 93:         for (Guid id : images.keySet()) {
Line 94:             List<DiskImage> list = images.get(id);
Line 95:             toReturn.getDiskMap().put(id, list.get(list.size() - 1));
on second thought - it doesn't make sense that the list will be empty.. so 
ignore..
Line 96:         }
Line 97: 
Line 98:         return toReturn;
Line 99:     }


-- 
To view, visit http://gerrit.ovirt.org/15626
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3bfc4094178d90e7b0583db4e427fc2b195a367d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to