Sahina Bose has posted comments on this change.
Change subject: gluster: Added queries for service list
......................................................................
Patch Set 9: (3 inline comments)
Also, please add unit tests for the 2 new dao methods
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterServiceQueryParameters.java
Line 11: private ServiceType serviceType;
Line 12:
Line 13: public GlusterServiceQueryParameters(Guid groupId) {
Line 14: super(groupId);
Line 15: }
Maybe a constructor that accepts id and serviceType as arguments?
Line 16:
Line 17: public ServiceType getServiceType() {
Line 18: return serviceType;
Line 19: }
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterServerServiceDaoDbFacadeImpl.java
Line 68: @Override
Line 69: public List<GlusterServerService>
getByClusterIdAndServiceType(Guid clusterId, ServiceType serviceType) {
Line 70: MapSqlParameterSource paramSource =
getCustomMapSqlParameterSource();
Line 71: paramSource.addValue("cluster_id", clusterId);
Line 72: paramSource.addValue("servive_type", serviceType);
Typo here. should be service_type
Line 73:
Line 74: return
getCallsHandler().executeReadList("GetGlusterServerServicesByClusterIdAndServiceType",
Line 75: serviceRowMapper, paramSource);
Line 76: }
Line 78: @Override
Line 79: public List<GlusterServerService> getByServerIdAndServiceType(Guid
serverId, ServiceType serviceType) {
Line 80: MapSqlParameterSource paramSource =
getCustomMapSqlParameterSource();
Line 81: paramSource.addValue("server_id", serverId);
Line 82: paramSource.addValue("servive_type", serviceType);
Typo here. should be service_type
Line 83:
Line 84: return
getCallsHandler().executeReadList("GetGlusterServerServicesByServerIdAndServiceType",
Line 85: serviceRowMapper, paramSource);
Line 86: }
--
To view, visit http://gerrit.ovirt.org/15122
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e027a49a5a5a49ff37ef78433a96b81add3f8d4
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
