Sahina Bose has posted comments on this change. Change subject: gluster: Added queries for service list ......................................................................
Patch Set 5: Looks good to me, but someone else must approve (1 inline comment) Minor suggestion inline .................................................... File frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties Line 232: VAR__TYPE__GLUSTER_VOLUME_REBALANCE=$type Gluster Volume Rebalance Line 233: VAR__TYPE__GLUSTER_BRICK=$type Gluster Brick Line 234: VAR__TYPE__GLUSTER_SERVER=$type Gluster Server Line 235: VAR__TYPE__GLUSTER_HOOK=$type Gluster Hook Line 236: VALIDATION.GLUSTER.GLUSTER_SERVICE_GROUP_ID.NOT_NULL=Cluster Id / Server Id is required. You could move this to be along with other VALIDATION messages Line 237: VAR__ACTION__RUN=$action run Line 238: VAR__ACTION__REMOVE=$action remove Line 239: VAR__ACTION__ADD=$action add Line 240: VAR__ACTION__CREATE=$action create -- To view, visit http://gerrit.ovirt.org/15122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e027a49a5a5a49ff37ef78433a96b81add3f8d4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
