Sahina Bose has posted comments on this change.
Change subject: gluster: Added queries for service list
......................................................................
Patch Set 1: (2 inline comments)
Minor comments inline
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterQueriesCommandBase.java
Line 34: protected GlusterHooksDao getGlusterHookDao() {
Line 35: return DbFacade.getInstance().getGlusterHooksDao();
Line 36: }
Line 37:
Line 38: protected GlusterServerServiceDao getGlusterServerServoceDao() {
Typo here - should be ServiceDao
Line 39: return DbFacade.getInstance().getGlusterServerServiceDao();
Line 40: }
Line 41:
Line 42: protected String getGlusterVolumeName(Guid volumeId) {
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterServiceQueryParameters.java
Line 6: public class GlusterServiceQueryParameters extends
VdcQueryParametersBase {
Line 7:
Line 8: private static final long serialVersionUID = -7687304241216035728L;
Line 9:
Line 10: private Guid groupId;
Can add not null validation here - see GlusterHookContentQueryParameters for
example
Line 11:
Line 12: public GlusterServiceQueryParameters(Guid groupId) {
Line 13: super();
Line 14: this.groupId = groupId;
--
To view, visit http://gerrit.ovirt.org/15122
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e027a49a5a5a49ff37ef78433a96b81add3f8d4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
