Kanagaraj M has posted comments on this change.
Change subject: gluster: Added queries for service list
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServiceByClusterIdQuery.java
Line 4:
Line 5: import
org.ovirt.engine.core.common.businessentities.gluster.GlusterServerService;
Line 6: import
org.ovirt.engine.core.common.queries.gluster.GlusterServiceQueryParameters;
Line 7:
Line 8: public class GetGlusterServiceByClusterIdQuery<P extends
GlusterServiceQueryParameters> extends GlusterQueriesCommandBase<P> {
This should be named as GetGlusterServerServicesByClusterIdQuery, to be inline
with the VdcQueryType enum. At runtime Backend will expect a class with name
vdcQueryType.getName()+"Query" .
Line 9:
Line 10: protected GetGlusterServiceByClusterIdQuery(P parameters) {
Line 11: super(parameters);
Line 12: }
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServiceByServerIdQuery.java
Line 4:
Line 5: import
org.ovirt.engine.core.common.businessentities.gluster.GlusterServerService;
Line 6: import
org.ovirt.engine.core.common.queries.gluster.GlusterServiceQueryParameters;
Line 7:
Line 8: public class GetGlusterServiceByServerIdQuery<P extends
GlusterServiceQueryParameters> extends GlusterQueriesCommandBase<P> {
This should be named as GetGlusterServerServicesByServerIdQuery
Line 9:
Line 10: protected GetGlusterServiceByServerIdQuery(P parameters) {
Line 11: super(parameters);
Line 12: }
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 805: VALIDATION.GLUSTER.BRICK.ID.NOT_NULL=Brick ID is required.
Line 806: VALIDATION.GLUSTER.VOLUME.BRICK.SERVER_ID.NOT_NULL=Brick Server ID is
required.
Line 807: VALIDATION.GLUSTER.VOLUME.BRICK.BRICK_DIR.NOT_NULL=Brick Directory is
required.
Line 808: VALIDATION.GLUSTER.GLUSTER_HOOK_ID.NOT_NULL=Gluster Hook ID is
required.
Line 809: VALIDATION.GLUSTER.GLUSTER_SERVICE_GROUP_ID.NOT_NULL=Cluster Id /
Server Id is required.
Please remove this space.
Also corresponding entries to frontend AppErrors is missing.
Line 810: ACTION_TYPE_FAILED_CLUSTER_IS_NOT_VALID=Cannot ${action} ${type}.
Cluster ID is not valid.
Line 811: ACTION_TYPE_FAILED_CLUSTER_DOES_NOT_SUPPORT_GLUSTER=Cannot ${action}
${type}. Cluster does not support Gluster service.
Line 812: ACTION_TYPE_FAILED_GLUSTER_VOLUME_NAME_ALREADY_EXISTS=Cannot
${action} ${type}. Volume name ${volumeName} already exists.
Line 813: ACTION_TYPE_FAILED_GLUSTER_VOLUME_INVALID=Cannot ${action} ${type}.
Gluster Volume is not valid.
--
To view, visit http://gerrit.ovirt.org/15122
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e027a49a5a5a49ff37ef78433a96b81add3f8d4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
