Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: force Apache proxy on upgrade
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 564: self.TMPAPACHECONF
Line 565: )
Line 566: handler = utils.TextConfigFileHandler(self.TMPAPACHECONF, " ")
Line 567: handler.open()
Line 568: handler.editParam("SSLCertificateFile",
basedefs.FILE_APACHE_CERT)
This is dangerous... if the user configured his own certificates...
I suggest testing if the defaults are there...
Line 569: handler.editParam("SSLCertificateKeyFile",
basedefs.FILE_APACHE_PRIVATE_KEY)
Line 570: handler.editParam("SSLCertificateChainFile",
basedefs.FILE_APACHE_CA_CRT_SRC)
Line 571: handler.close()
Line 572:
Line 1076: utils.editEngineSysconfigProtocols(
Line 1077: fqdn=fqdn,
Line 1078: http='80',
Line 1079: https='443',
Line 1080: )
This is dangerous... as if there was already configuration of proxy then we
overwrite it. We discussed the possibility (3) apache with non standard ports.
So your previous detection mechanism was OK... to detect if there was no proxy
defined, and only if there was no proxy, and only then, we perform these
changes (this and SSL).
Line 1081:
Line 1082:
Line 1083: def deleteEngineSysconfig():
Line 1084: # Delete the old configuration file and the backup made by RPM:
--
To view, visit http://gerrit.ovirt.org/15051
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib46bcf40acff860cd3e52634ade683d7a8836cf6
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
