Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: force Apache proxy on upgrade ......................................................................
Patch Set 2: (1 inline comment) .................................................... File packaging/fedora/setup/engine-upgrade.py Line 211: help=output_messages.INFO_CONF_PARAMS_HTTPS_PORT_USAGE, Line 212: action='store', Line 213: dest='https', Line 214: default='443' Line 215: ) But do you expect admin to configure httpd by hand? I think this should be removed. If jboss already configured to use http/https then it can continue serving at that port. If apache already set on different port it remains. All we add is AJP to current apache configuration, no? Line 216: Line 217: (options, args) = parser.parse_args() Line 218: return (options, args) Line 219: -- To view, visit http://gerrit.ovirt.org/15051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib46bcf40acff860cd3e52634ade683d7a8836cf6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
